-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove arcane dependency #1542
Merged
andreasknoepfle
merged 19 commits into
fairmondo:develop
from
bitcrowd:remove-arcane-dependency
Feb 6, 2020
Merged
Remove arcane dependency #1542
andreasknoepfle
merged 19 commits into
fairmondo:develop
from
bitcrowd:remove-arcane-dependency
Feb 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juffel
force-pushed
the
remove-arcane-dependency
branch
from
February 6, 2020 15:21
3a010b1
to
de79733
Compare
juffel
force-pushed
the
remove-arcane-dependency
branch
from
February 6, 2020 16:24
547f922
to
a46117f
Compare
juffel
force-pushed
the
remove-arcane-dependency
branch
from
February 6, 2020 16:32
a46117f
to
af604f3
Compare
juffel
commented
Feb 6, 2020
andreasknoepfle
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
arcane
gem and simply uses strong paramaters instead of arcane refinery definitions.