Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add missing environment variables #446

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

AnyTimeTraveler
Copy link
Contributor

Fixes #443 and #445

The function env_init in line 622 clears the whole environment.
After adding the environment variables generated in lines 508 and 509 back in, everything works as it should.

I don't know enough about the rest of the code to know if the lines 508 and 509 can now be removed, so I didn't remove them yet.
I'd like some help from someone more experienced, if the variables are needed anywhere between the first setting (line 508) and the clearing (line 622).

You can see in #425 (link to the specific line)that the function env_xdg used to be called before env_init.

@AnyTimeTraveler
Copy link
Contributor Author

I just booted my PC a second time and had the same problem again, but this time sway is saying that there is no seat available.
I am going to investigate further before this should be merged.

@AnyTimeTraveler
Copy link
Contributor Author

AnyTimeTraveler commented Oct 3, 2022

Okay, there must be some kind of race-condition here, as I have rebooted my PC 5 more times and each time logging into sway worked flawlessly.
For now, this pull request definitely corrects the resetting of the environment after XDG_RUNTIME_DIR is set.

@AnyTimeTraveler AnyTimeTraveler marked this pull request as ready for review October 3, 2022 12:01
@AnErrupTion AnErrupTion merged commit 77eb456 into fairyglade:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ly starts login-sessions as root instead of as the user who logged in
2 participants