Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong DuckDuckGo detection #730

Closed
AKaravas opened this issue May 21, 2024 · 0 comments
Closed

wrong DuckDuckGo detection #730

AKaravas opened this issue May 21, 2024 · 0 comments

Comments

@AKaravas
Copy link

Library version
"@ua-parser-js/pro-business": "^2.0.0-beta.2",

Describe the bug
Tried to get some data from DuckDuckGo, but it recognized it as Safari (partially right)

To Reproduce
just console log the UA while visiting your page from DuckDuckGo

Expected behavior
Expected to get DuckDuckGo as name in the browser Object

Screenshots
Screenshot 2024-05-21 at 18 47 00

Desktop (please complete the following information):

  • OS:MacOsX
  • Browser DuckDuckGo
  • Version 1.88.0 (189)

Additional context
As you can see in the UA, the Ddg/17.4.1 is present, i believe Ddg stands for DuckDuckGo
faisalman added a commit that referenced this issue May 28, 2024
@faisalman
Backport - Fix #730 - Improve browser detection: DuckDuckGo
e7bfc4e 
(cherry picked from commit e87c794)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AKaravas