Added Support for Wasabi and Digital Ocean #64
Conversation
nghiapham1026
commented
Jul 31, 2023
nghiapham1026
commented
- Added a hook for Wasabi at /apps/web/pages/new/wasabi.tsx that is based on the AWS S3 hook, including the login page and necessary functions for Wasabi.
- Added a hook for Digital Ocean at /apps/web/pages/new/digitalocean.tsx that is based on the AWS S3 hook, including the login page and necessary functions for Digital Ocean.
- Made changes to /apps/web/hooks/useBucket.tsx and /apps/web/hooks/useS3.tsx to reflect the addition of Wasabi and Digital Ocean as supported providers.
- Made changes to /apps/web/util/types.ts and /apps/web/util/types.ts to include the logos and buttons for Wasabi and Digital Ocean in the main page. Created a condition that checks for the presence of only one of the RESEND_API_KEY or SENDGRID_API_KEY, which can only run if one of them is set to "undefined," to minimize conflicts.
- Made changes to /apps/web/util/helpers/s3-helpers.ts to allow the creation of Digital Ocean and Wasabi drives and facilitate the fetching of objects to the drive.
- Minor cosmetic changes to the web page and code readability.
…bals.ts, types.ts
Made changes to wasabiProvider.tsx, useBucket.tsx, useWasabi.tsx, glo…
Changes to Wasabi loading page
Merging updates from original branch
Added Digital Ocean integration to the API
.env and added Wasabi cases to s3-helpers
|
This pull request is ready to be reviewed and merged. |
| @@ -29,10 +29,13 @@ export const createNewBucket = async ( | |||
| }; | |||
|
|
|||
| export const beforeCreatingDoc = async (req: NextApiRequest, res: NextApiResponse, body: any) => { | |||
|
|
|||
| const { data, type } = body; | |||
|
|
|||
| switch (type) { | |||
| case "firebase": | |||
There was a problem hiding this comment.
@nghiapham1026 @9brian we might want to store these as global constants in the future so it can be used across different files, i.e. in one file firebase might be misspelled but here it is spelled correctly
There was a problem hiding this comment.
forgot to add, but constants help prevent these inconsistencies
|
@nghiapham1026 @ConlynPattison any updates? just confirming if all the above changes are done. if so, I'll merge it |
|
Also, I am getting this error, can you guys please check what's wrong? |
|
ah I think the error is related to this: there should not be a package.json file outside the |
|
@faisalsayed10 There was not any error in the codebase when we first made the pull request. However, the error only persists when we merged the Cloudflare change from the main branch. I think there is some merge conflict between Cloudflare and our code that is causing the error. |
|
I see, even then, please check my previous comment on how package.json shouldn't exist on the root path |
I removed the package.json file from the root path. |
|
Just tested the app, and everything works perfectly. Appreciate the work, thank you so much! |
