Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Entire pages are off-center in specific scenarios. #22

Closed
3vorp opened this issue Mar 26, 2023 · 1 comment
Closed

[Bug] Entire pages are off-center in specific scenarios. #22

3vorp opened this issue Mar 26, 2023 · 1 comment
Labels
visual bug Something that bothers people but do work

Comments

@3vorp
Copy link
Contributor

3vorp commented Mar 26, 2023

What happened?

Pretty much exactly what the title says — by opening and collapsing the navigation menu in specific orders you can cause pages to not center properly.

To reproduce

  1. Go to https://docs.faithfulpack.net/.
  2. Open the navigation sidebar.
  3. Navigate to any article that does not contain a table of contents.
  4. Collapse the navigation sidebar.
  5. Notice how the whole page is off centered to the left.

This persists even after clicking through any number of articles and even on the home page, until you refresh the site.

Screenshot(s)

with the bug:
Screen Shot 2023-03-26 at 11 54 58 AM
how it's supposed to look:
Screen Shot 2023-03-26 at 11 55 13 AM

Browser name and version

Brave Version 1.49.128
Chromium: 111.0.5563.110

Notes

May be related to the table of contents since it seems to be offset by the right amount to make the table of contents fit if there was one.

Ideally implement #20 if this is part of the issue.

@3vorp 3vorp added the bug Something isn't working label Mar 26, 2023
@TheRolfFR TheRolfFR added visual bug Something that bothers people but do work and removed bug Something isn't working labels May 21, 2023
@TheRolfFR
Copy link
Member

Culprit seems to be;

if(!toc) return;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
visual bug Something that bothers people but do work
Projects
None yet
Development

No branches or pull requests

2 participants