Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Salt #4

Closed
bglogic opened this issue Jun 4, 2016 · 11 comments
Closed

Invalid Salt #4

bglogic opened this issue Jun 4, 2016 · 11 comments

Comments

@bglogic
Copy link

bglogic commented Jun 4, 2016

I get an [Invalid salt] message when trying to login after creating an account and confirming the email.

@fake-name
Copy link
Owner

Well, that's annoying. I did recently update the session management stuff, let me see if that's the source of the issue.

@fake-name
Copy link
Owner

Ok, so one of the libraries is now broken. Let me see if I can figure out what happened,

fake-name added a commit that referenced this issue Jun 5, 2016
Thanks so much for the report!
@fake-name
Copy link
Owner

fake-name commented Jun 5, 2016

Flask-bcrypt started doing type conversions in a way that broke authentication everywhere, apparently. It's fixed now, in any event.

Accounts with passwords generated when flask was being dumb should be automatically patched when they login now too.

@bglogic
Copy link
Author

bglogic commented Mar 22, 2019

This issue is back again

@fake-name
Copy link
Owner

Can you tell me the username you're seeing the issue from?

Alternatively, e-mail it to me at admin@wlnupdates.com, if you don't want it to be public.

@bglogic
Copy link
Author

bglogic commented Mar 22, 2019

smmalmansoori

@bglogic
Copy link
Author

bglogic commented Mar 22, 2019

Don't know if you did something on your side yet but now its working again

@fake-name
Copy link
Owner

I've been futzing with the auth packages trying to figure out what's going on.

There's some fiddly install-order-dependent things going on, not sure what.

fake-name added a commit that referenced this issue Mar 22, 2019
I think it was the installation of python-bcrypt, but really,  ¯\_(ツ)_/¯.
@bglogic
Copy link
Author

bglogic commented Mar 22, 2019

Don't know how much this would help but maybe it would help by simplifying your dependencies for example:

  • remove flask-security (last release on on Jun 14, 2017) and use flask-login directly
  • remove flask-bcrypt and use generate_password_hash

@fake-name
Copy link
Owner

Yeah, I mean, mostly my concern is breaking the currently functional (?) auth.

I would hope this sort of thing would be stable, but apparently that's too much to ask.

@bglogic
Copy link
Author

bglogic commented Mar 22, 2019

You'll need to rehash with the new method on successful login. This way the old method will be eventually phased out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants