Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable settings #8

Closed
chripede opened this issue Feb 27, 2015 · 2 comments
Closed

Configurable settings #8

chripede opened this issue Feb 27, 2015 · 2 comments

Comments

@chripede
Copy link

I'd like to be able to change settings like BROWSERS_COUNT_LIMIT.
Maybe just as a parameter to the update method.
@hellysmile
Copy link
Collaborator

Feel to free to make pull request...

@hellysmile
Copy link
Collaborator

Bit tricky, but I don't want to make settings configurable, at least I can not see any reason for this...

from fake_useragent import settings


settings.BROWSERS_COUNT_LIMIT = 42

from fake_useragent import UserAgent

melroy89 added a commit that referenced this issue Nov 2, 2022
@melroy89
Merge pull request #8 from scmanjarrez/master
a8f2b57 
Fix regexp to match user agent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chripede @hellysmile