Fix Dir.entries on ruby-2.1.0-preview2

[benjaminoakes]

Ruby 2.1.0's Dir.entries method now allows an "encoding" option. Without this change, ArgumentError: wrong number of arguments (2 for 1) is raised.

See also http://ruby-doc.org/core-2.1.0/Dir.html

I found this while working on Ruby 2.1.0 compatibility for Maid. As a part of debugging Maid's specs, I extracted a minimal spec that demonstrates the problem. It's currently in spec/fakefs/fakefs_bug_ruby_2.1.0-preview2.rb.

Thanks for maintaining FakeFS. It makes Maid's specs much easier to write!

Ben

[eventualbuddha]

According to the docs the second argument here is an encoding, which I take to mean a string. This should probably be called encoding and default to nil.

[benjaminoakes]

I could see changing the name from opts. However, I don't think it can be nil -- it's expecting a hash, according to the docs (encoding: enc). Perhaps this?

def self.entries(dirname, opts = { :encoding => nil })

Or if you're okay with new syntax:

def self.entries(dirname, encoding: nil)

[eventualbuddha]

You're right, I was misreading the docs. I believe this is fine as-is.

[eventualbuddha]

Could you give a little more detail how Find.find interacts with Dir.entries to cause the error you're seeing in Ruby 2.1?

[benjaminoakes]

Unfortunately, I don't know all the mechanics of how Find.find interacts with Dir.entries, just that fakefs ends up calling Dir.entries when Find.find is called. For more details, it might be helpful to see this blog entry that I wrote.

The purpose of this pull request is to demonstrate that Dir.entries has changed in Ruby 2.1 and that a second argument needs to be handled in fakefs. The test case in spec/fakefs/fakefs_bug_ruby_2.1.0-preview2.rb is one example. It would seem that other calls that involve Dir.entries would break on Ruby 2.1 as well.

I hope this helps clarify the issue! Really, it's just a one line change to be compatible with Ruby 2.1.