Skip to content

Commit

Permalink
chore: remove generics (#2393)
Browse files Browse the repository at this point in the history
Co-authored-by: xDivisionByZerox <leyla.jaehnig@gmx.de>
  • Loading branch information
Shinigami92 and xDivisionByZerox committed Sep 15, 2023
1 parent 845f329 commit 1db38c2
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions src/modules/date/index.ts
Expand Up @@ -23,8 +23,8 @@ function toDate(
return date;
}

export class SimpleDateModule<TFaker extends SimpleFaker = SimpleFaker> {
constructor(protected readonly faker: TFaker) {
export class SimpleDateModule {
constructor(protected readonly faker: SimpleFaker) {
bindThisToMemberFunctions(this);
}

Expand Down Expand Up @@ -914,8 +914,8 @@ export class SimpleDateModule<TFaker extends SimpleFaker = SimpleFaker> {
*
* These methods have additional concerns about reproducibility, see [Reproducible Results](https://fakerjs.dev/guide/usage.html#reproducible-results).
*/
export class DateModule extends SimpleDateModule<Faker> {
constructor(faker: Faker) {
export class DateModule extends SimpleDateModule {
constructor(protected readonly faker: Faker) {
super(faker);
}

Expand Down
8 changes: 4 additions & 4 deletions src/modules/helpers/index.ts
Expand Up @@ -158,7 +158,7 @@ function legacyRegexpStringParse(
return string;
}

export class SimpleHelpersModule<TFaker extends SimpleFaker = SimpleFaker> {
export class SimpleHelpersModule {
/**
* Global store of unique values.
* This means that faker should *never* return duplicate values across all API methods when using `faker.helpers.unique` without passing `options.store`.
Expand All @@ -167,7 +167,7 @@ export class SimpleHelpersModule<TFaker extends SimpleFaker = SimpleFaker> {
*/
private readonly uniqueStore: Record<RecordKey, RecordKey> = {};

constructor(protected readonly faker: TFaker) {
constructor(protected readonly faker: SimpleFaker) {
bindThisToMemberFunctions(this);
}

Expand Down Expand Up @@ -1246,8 +1246,8 @@ export class SimpleHelpersModule<TFaker extends SimpleFaker = SimpleFaker> {
*
* A number of methods can generate strings according to various patterns: [`replaceSymbols()`](https://fakerjs.dev/api/helpers.html#replacesymbols), [`replaceSymbolWithNumber()`](https://fakerjs.dev/api/helpers.html#replacesymbolwithnumber), and [`fromRegExp()`](https://fakerjs.dev/api/helpers.html#fromregexp).
*/
export class HelpersModule extends SimpleHelpersModule<Faker> {
constructor(faker: Faker) {
export class HelpersModule extends SimpleHelpersModule {
constructor(protected readonly faker: Faker) {
super(faker);
}

Expand Down

0 comments on commit 1db38c2

Please sign in to comment.