fix: removed dead code and added missing types

faker-js · Jan 25, 2022 · 3e9d1e6 · 3e9d1e6
1 parent 9b3d6b5
commit 3e9d1e6
Showing 1 changed file with 6 additions and 43 deletions.
diff --git a/src/system.ts b/src/system.ts
@@ -47,7 +47,7 @@ export class System {
    * @example
    * faker.system.fileName() // 'self_enabling_accountability_toys.kpt'
    */
-  fileName() {
+  fileName(): string {
     let str = this.faker.random.words();
     str =
       str.toLowerCase().replace(/\W/g, '_') + '.' + this.faker.system.fileExt();
@@ -76,25 +76,7 @@ export class System {
    * @example
    * faker.system.mimeType() // 'video/vnd.vivo'
    */
-  mimeType() {
-    const typeSet = new Set<string>();
-    const extensionSet = new Set();
-    const mimeTypes = this.faker.definitions.system.mimeTypes;
-
-    Object.keys(mimeTypes).forEach((m) => {
-      const type = m.split('/')[0];
-
-      typeSet.add(type);
-
-      if (mimeTypes[m].extensions instanceof Array) {
-        mimeTypes[m].extensions.forEach((ext) => {
-          extensionSet.add(ext);
-        });
-      }
-    });
-
-    const types = setToArray(typeSet);
-    const extensions = setToArray(extensionSet);
+  mimeType(): string {
     const mimeTypeKeys = Object.keys(this.faker.definitions.system.mimeTypes);
 
     return this.faker.random.arrayElement(mimeTypeKeys);
@@ -106,7 +88,7 @@ export class System {
    * @example
    * faker.system.commonFileType() // 'audio'
    */
-  commonFileType() {
+  commonFileType(): string {
     return this.faker.random.arrayElement(commonFileTypes);
   }
 
@@ -116,7 +98,7 @@ export class System {
    * @example
    * faker.system.commonFileExt() // 'gif'
    */
-  commonFileExt() {
+  commonFileExt(): string {
     return this.faker.system.fileExt(
       this.faker.random.arrayElement(commonMimeTypes)
     );
@@ -128,7 +110,7 @@ export class System {
    * @example
    * faker.system.fileType() // 'message'
    */
-  fileType() {
+  fileType(): string {
     const typeSet = new Set<string>();
     const extensionSet = new Set();
     const mimeTypes = this.faker.definitions.system.mimeTypes;
@@ -146,8 +128,6 @@ export class System {
     });
 
     const types = setToArray(typeSet);
-    const extensions = setToArray(extensionSet);
-    const mimeTypeKeys = Object.keys(this.faker.definitions.system.mimeTypes);
     return this.faker.random.arrayElement(types);
   }
 
@@ -161,25 +141,8 @@ export class System {
    * faker.system.fileExt('application/json') // 'json'
    */
   fileExt(mimeType?: string): string {
-    const typeSet = new Set<string>();
     const extensionSet = new Set<string>();
-    const mimeTypes = this.faker.definitions.system.mimeTypes;
-
-    Object.keys(mimeTypes).forEach((m) => {
-      const type = m.split('/')[0];
-
-      typeSet.add(type);
-
-      if (mimeTypes[m].extensions instanceof Array) {
-        mimeTypes[m].extensions.forEach((ext) => {
-          extensionSet.add(ext);
-        });
-      }
-    });
-
-    const types = setToArray(typeSet);
     const extensions = setToArray(extensionSet);
-    const mimeTypeKeys = Object.keys(this.faker.definitions.system.mimeTypes);
 
     if (mimeType) {
       const mimes = this.faker.definitions.system.mimeTypes;
@@ -206,7 +169,7 @@ export class System {
    * @example
    * faker.system.filePath() // '/usr/local/src/money.rmp.dotx'
    */
-  filePath() {
+  filePath(): string {
     return this.faker.fake(
       '{{system.directoryPath}}/{{system.fileName}}.{{system.fileExt}}'
     );