feat(number): adjust hex default (#1649)

faker-js · Dec 10, 2022 · 7b50c2f · 7b50c2f
1 parent ab9fa1f
commit 7b50c2f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/modules/number/index.ts b/src/modules/number/index.ts
@@ -117,12 +117,12 @@ export class NumberModule {
    *
    * @param options Maximum value or options object. Defaults to `{}`.
    * @param options.min Lower bound for generated number. Defaults to `0`.
-   * @param options.max Upper bound for generated number. Defaults to `min + 16`.
+   * @param options.max Upper bound for generated number. Defaults to `15`.
    *
    * @example
    * faker.number.hex() // 'b'
-   * faker.number.hex(16) // '9'
-   * faker.number.hex({ min: 0, max: 65536 }) // 'af17'
+   * faker.number.hex(255) // '9d'
+   * faker.number.hex({ min: 0, max: 65535 }) // 'af17'
    *
    * @since 8.0.0
    */
@@ -131,7 +131,7 @@ export class NumberModule {
       options = { max: options };
     }
 
-    const { min = 0, max = min + 16 } = options;
+    const { min = 0, max = 15 } = options;
 
     return this.int({
       max,

diff --git a/test/__snapshots__/number.spec.ts.snap b/test/__snapshots__/number.spec.ts.snap
@@ -24,7 +24,7 @@ exports[`number > 42 > float > with min, max and precision 1`] = `-0.4261`;
 
 exports[`number > 42 > float > with plain number 1`] = `1.5`;
 
-exports[`number > 42 > hex > noArgs 1`] = `"6"`;
+exports[`number > 42 > hex > noArgs 1`] = `"5"`;
 
 exports[`number > 42 > hex > with options 1`] = `"4"`;
 
@@ -60,7 +60,7 @@ exports[`number > 1211 > float > with min, max and precision 1`] = `61.0658`;
 
 exports[`number > 1211 > float > with plain number 1`] = `3.72`;
 
-exports[`number > 1211 > hex > noArgs 1`] = `"f"`;
+exports[`number > 1211 > hex > noArgs 1`] = `"e"`;
 
 exports[`number > 1211 > hex > with options 1`] = `"a"`;