refactor(finance)!: simplify account implementation (#1992)

faker-js · Apr 3, 2023 · de078de · de078de
1 parent edc50b6
commit de078de
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 22 deletions.
diff --git a/src/modules/finance/index.ts b/src/modules/finance/index.ts
@@ -135,19 +135,9 @@ export class FinanceModule {
       options = { length: options };
     }
 
-    let { length = 8 } = options;
-    if (length === 0) {
-      length = 8;
-    }
-
-    let template = '';
+    const { length = 8 } = options;
 
-    for (let i = 0; i < length; i++) {
-      template += '#';
-    }
-
-    length = null;
-    return this.faker.helpers.replaceSymbolWithNumber(template);
+    return this.faker.string.numeric({ length, allowLeadingZeros: true });
   }
 
   /**

diff --git a/test/finance.spec.ts b/test/finance.spec.ts
@@ -123,16 +123,6 @@ describe('finance', () => {
           ).toHaveLength(8);
         });
 
-        it('should supply a default length if a zero is passed', () => {
-          const accountNum = faker.finance.account(0);
-
-          expect(accountNum).toBeTruthy();
-          expect(
-            accountNum,
-            'The length of the account number should be 8 characters long'
-          ).toHaveLength(8);
-        });
-
         it('should be the the length fo given number', () => {
           const accountNum = faker.finance.account(16);