feat: migrate name #103
Merged
feat: migrate name #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
changed the title
Shinigami92
requested changes
Jan 12, 2022
Shinigami92
reviewed
Jan 12, 2022
27 tasks
Shinigami92
force-pushed
the
migrate-to-typescript
branch
2 times, most recently
from
24a00c3
to
3db7e8b
Compare
Shinigami92
force-pushed
the
migrate-name-2
branch
from
4e9365b
to
b714f65
Compare
Shinigami92
reviewed
Jan 13, 2022
Shinigami92
approved these changes
Jan 13, 2022
Shinigami92
force-pushed
the
migrate-to-typescript
branch
from
fc36e2f
to
7b02094
Compare
prisis
approved these changes
Jan 13, 2022
Shinigami92
force-pushed
the
migrate-name-2
branch
from
1138147
to
568c167
Compare
prisis
reviewed
Jan 13, 2022
| firstName ||= this.faker.name.firstName(gender); | ||
| lastName ||= this.faker.name.lastName(gender); | ||
|
|
||
| switch (r) { |
There was a problem hiding this comment.
Just a note, this should be later transformed to a if
prisis
approved these changes
Jan 13, 2022
Shinigami92
force-pushed
the
migrate-name-2
branch
from
568c167
to
cc70b56
Compare
Shinigami92
added a commit
that referenced
this pull request
Jan 14, 2022
Co-authored-by: Shinigami92 <chrissi92@hotmail.de>
Shinigami92
added a commit
that referenced
this pull request
Jan 14, 2022
Co-authored-by: Shinigami92 <chrissi92@hotmail.de>
damienwebdev
pushed a commit
that referenced
this pull request
Jan 14, 2022
Co-authored-by: Shinigami92 <chrissi92@hotmail.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #72.
Test with
npm run build && npx mocha test/name.unit.js