-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to typescript #72
Conversation
Hi @Shinigami92, Did you already add a |
It's a draft PR for a reason 😅 |
Ahah, OK no worries. 🙈 {
"compilerOptions": {
"module": "commonjs",
"declaration": true,
"removeComments": true,
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"allowSyntheticDefaultImports": true,
"esModuleInterop": true,
"forceConsistentCasingInFileNames": true,
"skipLibCheck": true,
"strict": true,
"target": "es2016",
"sourceMap": true,
"outDir": "./dist",
"baseUrl": "./",
"incremental": true
},
} |
A PR based on this PR would be helpful here |
0e7e1ba
to
64b8db8
Compare
fc36e2f
to
7b02094
Compare
✔️ Deploy Preview for vigilant-wescoff-04e480 ready! 🔨 Explore the source changes: 23e4498 🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e1de10954bd3000731c030 😎 Browse the preview: https://deploy-preview-72--vigilant-wescoff-04e480.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Shinigami92 <chrissi92@hotmail.de>
Co-authored-by: Shinigami92 <chrissi92@hotmail.de>
1705b9d
to
23e4498
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Rebased into main as 2cc42f2 |
This is the base branch of the TS migration
Please do not squash-merge this branch
How to test this PR
Use
npm build
and then runnpx mocha test/<module>.unit.js
to test the specific moduledatatype
is already working as an example!We will create distinct PRs for each module and base them on this PR so a review can be simply made
After that we merge all together and then look that all (untouched) tests are running
List of PRs
Legend:
GraphViz Source