Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(number): adjust hex default #1649

Merged
merged 3 commits into from
Dec 10, 2022
Merged

feat(number): adjust hex default #1649

merged 3 commits into from
Dec 10, 2022

Conversation

Shinigami92
Copy link
Member

While working on

I found that the hex default max are off by 1
We wanted to generate numbers from 0-f and so on, but the +16 instead of +15 generated 0-10 instead

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent m: number Something is referring to the number module labels Dec 9, 2022
@Shinigami92 Shinigami92 self-assigned this Dec 9, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner December 9, 2022 12:50
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #1649 (77767b4) into next (ab9fa1f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1649      +/-   ##
==========================================
- Coverage   99.64%   99.63%   -0.02%     
==========================================
  Files        2221     2221              
  Lines      240108   240108              
  Branches     1054     1049       -5     
==========================================
- Hits       239261   239236      -25     
- Misses        826      851      +25     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/number/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 84.05% <0.00%> (-6.76%) ⬇️

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a hint in the upgrade docs?

@ST-DDT ST-DDT added c: feature Request for new feature s: accepted Accepted feature / Confirmed bug labels Dec 9, 2022
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Dec 9, 2022
@ST-DDT ST-DDT requested review from a team December 9, 2022 13:29
@Shinigami92
Copy link
Member Author

Do we need a hint in the upgrade docs?

I think no, as this is a new function in v8 and the old is not touched
When the user already moves to the new one, they can expect these changes already

@Shinigami92 Shinigami92 enabled auto-merge (squash) December 10, 2022 19:09
@Shinigami92 Shinigami92 merged commit 7b50c2f into next Dec 10, 2022
@ST-DDT ST-DDT deleted the feat-adjust-hex-default branch December 10, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature m: number Something is referring to the number module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants