Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(locale): split de_CH first names into male and female #1692

Merged
merged 2 commits into from Dec 31, 2022

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Dec 26, 2022

This was done by hand, with some sanity-checking using https://genderize.io/

I left Dominique in both lists as it seems pretty gender neural in Switzerland:
https://www.google.com/search?q=Dominique+site:ch&tbm=isch

split from #1677

@matthewmayer matthewmayer requested a review from a team as a code owner December 26, 2022 16:11
@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #1692 (5354cf9) into next (2d93e6f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 5354cf9 differs from pull request most recent head efb306a. Consider uploading reports for the commit efb306a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1692      +/-   ##
==========================================
+ Coverage   99.64%   99.65%   +0.01%     
==========================================
  Files        2240     2242       +2     
  Lines      240190   240093      -97     
  Branches     1068     1072       +4     
==========================================
- Hits       239330   239258      -72     
+ Misses        839      814      -25     
  Partials       21       21              
Impacted Files Coverage Δ
src/locales/de_CH/person/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/de_CH/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/de_CH/person/index.ts 100.00% <100.00%> (ø)
src/locales/de_CH/person/male_first_name.ts 100.00% <100.00%> (ø)
src/internal/mersenne/twister.ts 95.95% <0.00%> (-0.05%) ⬇️
src/faker.ts 95.08% <0.00%> (-0.04%) ⬇️
src/modules/helpers/index.ts 99.14% <0.00%> (-0.02%) ⬇️
src/modules/word/index.ts 98.25% <0.00%> (-0.01%) ⬇️
src/modules/helpers/unique.ts 98.73% <0.00%> (-0.01%) ⬇️
src/modules/random/index.ts 98.98% <0.00%> (-0.01%) ⬇️
... and 26 more

@import-brain import-brain requested a review from a team December 26, 2022 16:25
@import-brain import-brain added c: chore PR that doesn't affect the runtime behavior c: locale Permutes locale definitions labels Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: locale Permutes locale definitions
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants