Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(locale): split ne first_names to female and male #1705

Merged
merged 4 commits into from Jan 3, 2023
Merged

chore(locale): split ne first_names to female and male #1705

merged 4 commits into from Jan 3, 2023

Conversation

matthewmayer
Copy link
Contributor

split from #1677
similar logic to #1692 but for ne

@matthewmayer matthewmayer requested a review from a team as a code owner January 1, 2023 10:30
@codecov
Copy link

codecov bot commented Jan 1, 2023 •
edited

Codecov Report

Merging #1705 (2119349) into next (b8c522e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1705   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2247     2249    +2     
  Lines      240410   240424   +14     
  Branches     1079     1079           
=======================================
+ Hits       239535   239549   +14     
  Misses        854      854           
  Partials       21       21
Impacted Files Coverage Δ
src/locales/ne/person/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/ne/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/ne/person/index.ts 100.00% <100.00%> (ø)
src/locales/ne/person/male_first_name.ts 100.00% <100.00%> (ø)

@import-brain import-brain added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions labels Jan 1, 2023
@Shinigami92 Shinigami92 requested review from import-brain and a team January 2, 2023 14:22
@Shinigami92 Shinigami92 changed the title chore(locale): split ne first_names to male and female chore(locale): split ne first_names to female and male Jan 3, 2023
@Shinigami92 Shinigami92 merged commit 84b3c20 into faker-js:next Jan 3, 2023
pladreyt pushed a commit to pladreyt/faker that referenced this pull request Jan 3, 2023
@pladreyt
chore(locale): split ne first_names to female and male (faker-js#1705)
c474eb3
pladreyt pushed a commit to pladreyt/faker that referenced this pull request Jan 3, 2023
@pladreyt
chore(locale): split ne first_names to female and male (faker-js#1705)
265514b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: chore PR that doesn't affect the runtime behavior c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewmayer @ST-DDT @Shinigami92 @import-brain