Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps)!: update dependency typescript to v5 #1953

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 20, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
typescript (source) ~4.9.5 -> ~5.3.3 age adoption passing confidence

Release Notes

Microsoft/TypeScript (typescript)

v5.3.3: TypeScript 5.3.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.3.2: TypeScript 5.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.2.2: TypeScript 5.2

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.1.6: TypeScript 5.1.6

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on npm

v5.1.5: TypeScript 5.1.5

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.1.3: TypeScript 5.1.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.0.4: TypeScript 5.0.4

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.0.3: TypeScript 5.0.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.0.2: TypeScript 5.0

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner March 20, 2023 00:29
@renovate renovate bot added the c: dependencies Pull requests that adds/updates a dependency label Mar 20, 2023
@renovate renovate bot force-pushed the renovate/major-typescript branch 3 times, most recently from f197bdc to ef4d4af Compare March 20, 2023 09:16
@Shinigami92
Copy link
Member

I assume this is currently just blocked by

because it currently cannot extract something for the docs

@ST-DDT
Copy link
Member

ST-DDT commented Mar 20, 2023

This might be blocked by #1952 as well and might need some manual updating as well.

@Shinigami92
Copy link
Member

This might be blocked by #1952 as well and might need some manual updating as well.

Are you sure?
Please have a look into the CI
To me these looks like they are not affected by the linting step at all 🤔

@ST-DDT
Copy link
Member

ST-DDT commented Mar 20, 2023

Please have a look into the CI

I did. The lint step is failing. Prettier requests some formatting to be applied to imports.
So either we have to update prettier or eslint or our source code. I dont know whether its an intentional change or one caused by an incompatibility. Why would updating typescript have an impact on the required import order?

We also have to update the test snapshots.

@Shinigami92
Copy link
Member

Please have a look into the CI

I did. The lint step is failing. Prettier requests some formatting to be applied to imports. So either we have to update prettier or eslint or our source code. I dont know whether its an intentional change or one caused by an incompatibility. Why would updating typescript have an impact on the required import order?

We also have to update the test snapshots.

Ah I see, I checked just the test CIs not the linting step.

But yes, somehow via the TS v5 <-> prettier changed 👀
I can not only observe this behavior in Faker, but also now in prettier/plugin-pug@54ffb01

@ST-DDT
Copy link
Member

ST-DDT commented Mar 20, 2023

Well from the diff it looks like it just sorts the imports alphabetically, so it might not be actually blocking, but something that might change again with future updates.

Since it doesnt hurt, should we do the required steps to merge this PR? Are you interested or should I do it?

@Shinigami92
Copy link
Member

Are you interested or should I do it?

I will try it :)

@Shinigami92 Shinigami92 added s: on hold Blocked by something or frozen to avoid conflicts do NOT merge yet Do not merge this PR into the target branch yet labels Mar 20, 2023
@Shinigami92
Copy link
Member

Okay, lets wait a bit so the eslint + prettier ecosystem can stabilize itself
I highly assume that TS v5 did define a new kind of sort order, this will be fetch from the TS language server from https://github.com/simonhaenisch/prettier-plugin-organize-imports and then processed via prettier. And this will then checked against eslint prettier/prettier rule (https://github.com/prettier/eslint-plugin-prettier).

All these components need to be working with each other, and instead of hard trying from our side to push this, we can maybe just wait a week or two and come back until all these developers and contributors had a bit of time to keep up :)

@renovate renovate bot force-pushed the renovate/major-typescript branch 12 times, most recently from 32c66a2 to f00fd20 Compare March 27, 2023 13:45
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa183ad) 99.56% compared to head (d60bc95) 99.57%.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #1953    +/-   ##
========================================
  Coverage   99.56%   99.57%            
========================================
  Files        2807     2807            
  Lines      250525   250526     +1     
  Branches     1149      742   -407     
========================================
+ Hits       249447   249466    +19     
- Misses       1050     1060    +10     
+ Partials       28        0    -28     
Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

... and 29 files with indirect coverage changes

@ST-DDT
Copy link
Member

ST-DDT commented Aug 6, 2023

It's okay from my side, but @ST-DDT should mark in his notes to reevaluate the ? generation when he switches to ts-ast / ts-morph and we get rid of typedoc

FFR: Refering to LiteralUnion<'a' | 'b'> -> 'a' | 'b' | ?

ST-DDT
ST-DDT previously approved these changes Feb 9, 2024
@ST-DDT ST-DDT self-assigned this Feb 9, 2024
@ST-DDT ST-DDT requested review from a team and Shinigami92 February 9, 2024 15:41
@renovate renovate bot requested a review from a team February 9, 2024 16:39
ST-DDT
ST-DDT previously approved these changes Feb 9, 2024
@ST-DDT ST-DDT requested a review from a team February 9, 2024 16:40
@renovate renovate bot force-pushed the renovate/major-typescript branch from decb83e to 3a83f30 Compare February 9, 2024 16:44
@Shinigami92 Shinigami92 changed the title chore(deps): update dependency typescript to v5 chore(deps)!: update dependency typescript to v5 Feb 9, 2024
@Shinigami92
Copy link
Member

We need to add a docs/guide/upgrading_v9/1953.md in this PR

@Shinigami92 Shinigami92 added the breaking change Cannot be merged when next version is not a major release label Feb 9, 2024
Copy link
Contributor Author

renovate bot commented Feb 9, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@ST-DDT ST-DDT merged commit bc3ebb7 into next Feb 9, 2024
16 checks passed
@Shinigami92 Shinigami92 deleted the renovate/major-typescript branch February 9, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Cannot be merged when next version is not a major release c: dependencies Pull requests that adds/updates a dependency
Projects
No open projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants