Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document supported locales #210

Closed
fzn0x opened this issue Jan 18, 2022 · 8 comments · Fixed by #248 or #252
Closed

docs: document supported locales #210

fzn0x opened this issue Jan 18, 2022 · 8 comments · Fixed by #248 or #252
Assignees
Labels
c: docs Improvements or additions to documentation c: feature Request for new feature good first issue Good for newcomers help wanted Extra attention is needed

Comments

@fzn0x
Copy link
Contributor

fzn0x commented Jan 18, 2022

Clear and concise description of the problem

Document supported locales in https://github.com/faker-js/faker/tree/main/locale

Avoid related issues and discussions (e.g #209)

Suggested solution

Write supported locales in https://github.com/faker-js/faker/tree/main/locale

Alternative

Additional context

  • Using table
  • Add navigation to locale README in main README.
@fzn0x fzn0x added the s: pending triage Pending Triage label Jan 18, 2022
@fzn0x fzn0x changed the title docs: document supported locale docs: document supported locales Jan 18, 2022
@MilosPaunovic MilosPaunovic added c: docs Improvements or additions to documentation c: feature Request for new feature good first issue Good for newcomers help wanted Extra attention is needed and removed s: pending triage Pending Triage labels Jan 18, 2022
@github-actions
Copy link

Hello @fncolon. We like your proposal/feedback and would appreciate a contribution via a Pull Request by you or another community member. We thank you in advance for your contribution and are looking forward to reviewing it!

@Shinigami92
Copy link
Member

We should do three things:

  1. Add the supported locales in the VitePress docs
  2. Add them in README.md (so that folks on the npm site can read it without the need of jump into docs but just searching with ctrl+f)
  3. Add an enum/string literal that defines the locales and export it + type the functions in TS
    But maybe it's possible to provide you own locale on demand from external, so it might need to be an LiteralUnion (see e.g. Literal String Union Autocomplete microsoft/TypeScript#29729 (comment))

@Shinigami92
Copy link
Member

Please also note that there is currently a huge PR that needs to be merged first, to reduce rebase/merge mess #169

@fzn0x
Copy link
Contributor Author

fzn0x commented Jan 18, 2022

We should do three things:

  1. Add the supported locales in the VitePress docs
  2. Add them in README.md (so that folks on the npm site can read it without the need of jump into docs but just searching with ctrl+f)
  3. Add an enum/string literal that defines the locales and export it + type the functions in TS
    But maybe it's possible to provide you own locale on demand from external, so it might need to be an LiteralUnion (see e.g. Literal String Union Autocomplete microsoft/TypeScript#29729 (comment))

Cool! especially number 3

@fzn0x
Copy link
Contributor Author

fzn0x commented Jan 18, 2022

Please also note that there is currently a huge PR that needs to be merged first, to reduce rebase/merge mess #169

Noted, thanks @Shinigami92

@Shinigami92
Copy link
Member

Update to my comment: #210 (comment)

We now already have: https://github.com/faker-js/faker#localization and https://fakerjs.dev/api/localization#localization
We don't have an automatisation for updating these.
Also I think we should link from the README.md to the official docs, so we don't need to keep the README.md up to date.

Also we want inline dev docs for the Faker constructor options.locale + LiteralUnion typed

@ST-DDT
Copy link
Member

ST-DDT commented Jan 21, 2022

I would like to do this.

@ST-DDT
Copy link
Member

ST-DDT commented Jan 21, 2022

This is covered completely by #248 (TS) and #252 (docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: feature Request for new feature good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants