lorem: Merge "supplemental" with "words" list #2153
Assignees
Labels
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
m: lorem
Something is referring to the lorem module
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Milestone
Comments
matthewmayer
added
p: 1-normal
|
In the Ruby Faker, there's an option to add supplemental:true to add the extra words https://www.rubydoc.info/gems/faker/Faker/Lorem#words-class_method I think this is probably overkill, given that Lorem is meant to be nonsense any way, there's not an easy way for a user of the function to know whether or not its a good idea to add more words. So I'd probably just merge the supplemental word lists into the main words one. |
matthewmayer
added a commit
to matthewmayer/faker
that referenced
this issue
Jul 6, 2023
fix faker-js#2153 - en: merge supplemental into words, sort and unique - he: deleted, as it was only latin words, but the he words list is Hebrew - dv: deleted, as identical to main words list - ur: merge supplemental into words, and unique - ja: merge supplemental into words - lv: merge supplemental into words, sort and unique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Whats the purpose of the "supplemental" vs "words" list? It seems the "supplemental" list is not used. Should they be merged into one?
Originally posted by @matthewmayer in #2147 (comment)
The text was updated successfully, but these errors were encountered: