Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha versions should not be published as latest on npm #225

Closed
marvinroger opened this issue Jan 19, 2022 · 7 comments
Closed

Alpha versions should not be published as latest on npm #225

marvinroger opened this issue Jan 19, 2022 · 7 comments

Comments

@marvinroger
Copy link

Describe the bug

Currently, v6.0.0-alpha.3 is published on npm under the latest tag. I think doing npm i @faker-js/faker should install the latest stable, not the latest alpha. Therefore, I'd suggest publishing v6.0.0-alpha.3 under the alpha tag (npm publish --tag alpha), and publishing a v5.5.4 (exact content of v5.5.3) under the latest tag.

Reproduction

Run npm i @faker-js/faker, it installs the latest alpha instead of the latest stable.

Additional Info

Note that maybe there's a valid reason to do so, I might be missing context here, since the library situation was/is quite complicated. 😉

@marvinroger marvinroger added the s: pending triage Pending Triage label Jan 19, 2022
@Shinigami92
Copy link
Member

You are right, but

Note that maybe there's a valid reason to do so, I might be missing context here, since the library situation was/is quite complicated.

that is somewhat theoretically the state.
Cause we already explicitly decided to create a new major version, we wanted to "inform" folks that there is that new version and to help us test it.
You are still free to use ^5.5.3 as range for now and it will use the old version. But please help us test the new v6 version.
We didn't change runtime code for now and we plan to not introduce runtime changes for the final 6.0.0 initial release.
It just has native TS support right now and you don't need @types/faker anymore.
Please also note that there were already some TS fixed already that are merged but not release yet under v6.0.0-alpha.4
We will release this next alpha in the next few days (hopefully 😃) and it will have esm and cjs / tree-shaking support 🎉

You may want to subscribe to #169 and #217

We also have a nice kind of Roadmap Board: https://github.com/orgs/faker-js/projects/2

@marvinroger
Copy link
Author

Alright, thanks for the quick reply! I'll let you close the ticket or leave it open for others to see.

@cdierkens
Copy link

You are still free to use ^5.5.3 as range for now and it will use the old version. But please help us test the new v6 version.

I think the confusion comes when you run a new install. Testing the Alpha should be opt in, and probably not the default.

@Shinigami92
Copy link
Member

Shinigami92 commented Jan 19, 2022

@cdierkens
Copy link

@cdierkens https://jubianchi.github.io/semver-check/#/^5.5.3/6.0.0-alpha.3

I wasn't arguing constraints. Constraints come into play when I already have a dependency in the package.json

But when I run yarn add --dev @faker-js/faker I would expect to get the latest non alpha or beta with the either the default prefix or ^ if I've configured that as my constraint prefix.

@marvinroger
Copy link
Author

Cause we already explicitly decided to create a new major version, we wanted to "inform" folks that there is that new version and to help us test it.

Personally, I can understand the situation right now, because the current v5 is tied to the old @types/faker, and it's important to get rid of this dependency so the project can start clean. Moreover, there are apparently no runtime code changes, so I'd say, for this transitional state, as long as it's exceptional, it's fine.

However, I hope future releases will indeed respect the latest tag to be the stable release, and that alpha and betas would be released under their respective npm tags.

@JessicaSachs
Copy link
Contributor

As per the above, won't fix. Going forward things will be normal and latest will be a non-alpha, non-beta version.

@xDivisionByZerox xDivisionByZerox removed the s: pending triage Pending Triage label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants