Browser is endless loading while generating string numeric with big range

[pschaub]

Pre-Checks

• Follow our Code of Conduct.
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Faker issue and not related to a combination with another package.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.
• I am willing to provide a PR.

Describe the bug

I tried to use faker.string.numeric({ length: { min: 10000000, max: 99999999 }) but my browser was hanging. I've tested it in Google Chrome 120.0.6099.71 and Microsoft Edge 120.0.2210.61.

I guess that this is a performance issue in the used algorithm, so that it doesn't scale well with huge numbers.

Minimal reproduction code

https://stackblitz.com/edit/faker-js-demo-gbihnb?file=index.ts

Additional Context

No response

Environment Info

System:
    OS: Linux 5.15 Ubuntu 22.04.3 LTS 22.04.3 LTS (Jammy Jellyfish)
    CPU: (16) x64 12th Gen Intel(R) Core(TM) i5-12600K
    Memory: 13.74 GB / 31.09 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
    Yarn: 1.22.21 - ~/.nvm/versions/node/v20.10.0/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v20.10.0/bin/npm
  Browsers:
    Chrome: 120.0.6099.71

Which module system do you use?

• CJS
• ESM

Used Package Manager

npm

[pschaub]

I got something mixed up here: the function faker.string.numeric({ length: { min: 10000000, max: 99999999 }) tries to generate a numeric string with a random character length between 10000000-99999999, instead of numbers in the range between 10000000-99999999.

I therefore think that nothing can be solved here within the library. I am therefore closing the ticket.

[ST-DDT]

If you haven't found it yet, faker.number.int() is probably what you are searching for.

[xDivisionByZerox]

Even with the "issue" resolved, this sounds like a performance issue for me. Am I wrong with that assumption?

[ST-DDT]

One faker.string.numeric({ length: { min: 10_000_000, max: 99_999_999 }) call takes ~20seconds for me.
That's ~2_500 (50kk/20k) chars per millisecond (ms). IMO that is acceptable.

[ST-DDT]

What is your expectation?

[pschaub]

If you haven't found it yet, faker.number.int() is probably what you are searching for.

I was looking for a string representation. But using faker.number.int() and afterwards converting it into a string works too.