Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed dead code and adjusted fileExt #304

Merged
merged 4 commits into from Feb 1, 2022
Merged

fix: removed dead code and adjusted fileExt #304

merged 4 commits into from Feb 1, 2022

Conversation

prisis
Copy link
Member

@prisis prisis commented Jan 25, 2022

No description provided.

@prisis prisis added this to the v6.0.0 - Project stability milestone Jan 25, 2022
@prisis prisis requested a review from a team as a code owner January 25, 2022 22:46
@prisis prisis self-assigned this Jan 25, 2022
@import-brain import-brain added the p: 1-normal Nothing urgent label Jan 26, 2022
@Shinigami92
Copy link
Member

Shinigami92 commented Jan 26, 2022 •
edited

Due to all the failing CI, I convert this to a draft for now

cannot look into what’s wrong from my phone 📱

@Shinigami92 Shinigami92 marked this pull request as draft January 26, 2022 06:19
@prisis
Copy link
Member Author

prisis commented Jan 26, 2022

Sorry forgot to do it yesterday, thanks

@Shinigami92 Shinigami92 added the needs rebase There is a merge conflict label Jan 30, 2022
@Shinigami92
Copy link
Member

Should be rebased after we merged #303

@prisis prisis force-pushed the feature/fix-type-and-dead-code branch from 3e9d1e6 to e569e94 Compare January 31, 2022 21:48
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Jan 31, 2022
ST-DDT
ST-DDT reviewed Jan 31, 2022
View reviewed changes
src/system.ts Show resolved Hide resolved
ST-DDT
ST-DDT reviewed Jan 31, 2022
View reviewed changes
src/system.ts Outdated Show resolved Hide resolved
@ST-DDT
Copy link
Member

ST-DDT commented Jan 31, 2022

You can update your PR title as there are no longer any added types.

@prisis prisis changed the title fix: removed dead code and added missing types fix: removed dead code and adjusted fileExt Jan 31, 2022
@prisis prisis marked this pull request as ready for review January 31, 2022 22:30
@ST-DDT ST-DDT requested a review from a team January 31, 2022 23:29
Shinigami92
Shinigami92 approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Shinigami92 Shinigami92 added the needs rebase There is a merge conflict label Feb 1, 2022
@Shinigami92
Copy link
Member

@prisis You need to press the update button, cause your PRs are not editable by us

@prisis prisis merged commit 471bc1d into faker-js:main Feb 1, 2022
@prisis prisis deleted the feature/fix-type-and-dead-code branch February 1, 2022 20:13
bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
@prisis @bmenant
fix: removed dead code and adjusted fileExt (faker-js#304)
54dfead
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@prisis @demipel8
fix: removed dead code and adjusted fileExt (faker-js#304)
5ebbbc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@prisis prisis

Labels
needs rebase There is a merge conflict p: 1-normal Nothing urgent
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prisis @Shinigami92 @ST-DDT @import-brain