Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): Properly setup eslint and decide on a set of rules or coding standard #34

Closed
3 tasks
ericjeker opened this issue Jan 9, 2022 · 3 comments · Fixed by #151
Closed
3 tasks
Assignees
Labels
c: feature Request for new feature

Comments

@ericjeker
Copy link
Contributor

  • Define the rules we wanna use? Should we start with eslint:recommended or the existing rules, something else?
  • Should we check the test folder? Currently, it's not covered.
  • ... other?
@damienwebdev
Copy link
Member

I think eslint:recommended would be a good starting point, likely whatever we can get done with a lint fix without breaking any tests is good.

For the moment, I don't think we should lint the test folder.

I would simply start by linting lib

@Shinigami92 Shinigami92 added the c: feature Request for new feature label Jan 9, 2022
@imrishabh18
Copy link
Contributor

@Shinigami92 I would like to take this up and setup the eslint for this project. 😁

@Shinigami92
Copy link
Member

@imrishabh18 Thanks for your help offer, but I think I will do this myself after I migrated the stuff to typescript this evening.
I have some very opinionated eslint setup and before we communicate back and forth and slow us down and do double work, ... I will do it myself 😅

@Shinigami92 Shinigami92 self-assigned this Jan 14, 2022
@Shinigami92 Shinigami92 linked a pull request Jan 15, 2022 that will close this issue
@Shinigami92 Shinigami92 added this to the v6.0 - Project stability milestone Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants