Skip to content

chore: setup improved linting#151

Merged
Shinigami92 merged 18 commits intomainfrom
setup-eslint
Jan 29, 2022
Merged

chore: setup improved linting#151
Shinigami92 merged 18 commits intomainfrom
setup-eslint

Conversation

@Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jan 15, 2022
@Shinigami92 Shinigami92 self-assigned this Jan 15, 2022
@netlify
Copy link

netlify bot commented Jan 15, 2022

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: 8fb4f8e

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61eb352c7327470007caf184

😎 Browse the preview: https://deploy-preview-151--vigilant-wescoff-04e480.netlify.app

@Shinigami92 Shinigami92 requested a review from a team January 15, 2022 10:33
prisis
prisis previously approved these changes Jan 15, 2022
@prisis
Copy link
Member

prisis commented Jan 15, 2022

The found issues will be fixed than in a new commit?

@Shinigami92
Copy link
Member Author

We may use continue-on-error for the last step in CI.
But on the other side that would be like an ignore all the errors 🤔

@prisis prisis added this to the v6.1.0 milestone Jan 16, 2022
@Shinigami92 Shinigami92 force-pushed the setup-eslint branch 2 times, most recently from ec49a8c to 8fb4f8e Compare January 21, 2022 22:35
@Shinigami92 Shinigami92 marked this pull request as ready for review January 21, 2022 22:44
@Shinigami92 Shinigami92 requested review from a team and prisis January 21, 2022 22:44
ejcheng
ejcheng previously approved these changes Jan 22, 2022
@Shinigami92 Shinigami92 requested a review from prisis January 23, 2022 09:14
@Shinigami92 Shinigami92 marked this pull request as draft January 24, 2022 19:05
@Shinigami92 Shinigami92 marked this pull request as ready for review January 24, 2022 19:17
@Shinigami92 Shinigami92 requested a review from a team January 24, 2022 19:23
@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Jan 25, 2022
@Shinigami92 Shinigami92 marked this pull request as draft January 26, 2022 14:37
also we want all ts files to be checked
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Jan 29, 2022
@Shinigami92 Shinigami92 marked this pull request as ready for review January 29, 2022 15:24
@Shinigami92 Shinigami92 requested review from a team and ST-DDT January 29, 2022 15:26
ST-DDT
ST-DDT previously approved these changes Jan 29, 2022
@Shinigami92 Shinigami92 requested review from a team and griest024 January 29, 2022 16:12
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Shinigami92 Shinigami92 dismissed griest024’s stale review January 29, 2022 17:53

will solve later

@Shinigami92 Shinigami92 merged commit 86beb83 into main Jan 29, 2022
@Shinigami92 Shinigami92 deleted the setup-eslint branch January 29, 2022 17:53
bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: chore PR that doesn't affect the runtime behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(lint): Properly setup eslint and decide on a set of rules or coding standard

6 participants