fix: remove unreachable code finance

[xDivisionByZerox]

Created in relation to #375

The original issue only stated code for the following if statement:

if (provider in localeFormat) {
    formats = localeFormat[provider]; // there could be multiple formats
    if (typeof formats === 'string') {
        format = formats;
    } else {
        format = this.faker.random.arrayElement(formats);
    }
}

I also found, that the last else statement:

else {
    // Choose a random provider
    // TODO ST-DDT 2022-01-30: #375 This is impossible to access
    if (typeof localeFormat === 'string') {
        format = localeFormat;
    } else if (typeof localeFormat === 'object') {
        // Credit cards are in a object structure
        formats = this.faker.random.objectElement(localeFormat, 'value'); // There could be multiple formats
        if (typeof formats === 'string') {
          format = formats;
        } else {
          format = this.faker.random.arrayElement(formats);
        }
    }
}

has the same problem. So I removed the unreachable parts as well.

[codecov]

Codecov Report

Merging #508 (50f27d0) into main (9ab0825) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 50f27d0 differs from pull request most recent head 00cd658. Consider uploading reports for the commit 00cd658 to get more accurate results

@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
+ Coverage   99.33%   99.34%   +0.01%     
==========================================
  Files        1920     1919       -1     
  Lines      176486   176318     -168     
  Branches      910      901       -9     
==========================================
- Hits       175308   175164     -144     
+ Misses       1122     1098      -24     
  Partials       56       56              

Impacted Files	Coverage Δ
src/finance.ts	100.00% <100.00%> (+0.67%)	⬆️
src/vendor/user-agent.ts	97.75% <0.00%> (-0.29%)	⬇️
src/system.ts	96.37% <0.00%> (-0.11%)	⬇️
src/git.ts	100.00% <0.00%> (ø)
src/date.ts	100.00% <0.00%> (ø)
src/fake.ts	100.00% <0.00%> (ø)
src/iban.ts	100.00% <0.00%> (ø)
src/time.ts	100.00% <0.00%> (ø)
src/word.ts	100.00% <0.00%> (ø)
src/phone.ts	100.00% <0.00%> (ø)
... and 20 more

[Shinigami92]

Somehow the node 14 test fails, could you have a look?

[ST-DDT]

FFR:

[ST-DDT]

@Shinigami92 I assume that test is wrong.

faker/test/random.spec.ts

Lines 180 to 187 in 431c108

	it('should be able to ban some characters', () => {
	const alphaText = faker.random.alphaNumeric(5, {
	bannedChars: ['a', 'p'],
	});
	expect(alphaText).toHaveLength(5);
	expect(alphaText).match(/[b-oq-z]/);
	});

faker/src/random.ts

Line 383 in 431c108

alphaNumeric(

It just has a very low chance of failing (~0.2%).

The test should be fixed like this:

- expect(alphaText).match(/[b-oq-z]/);
+ expect(alphaText).match(/^[0-9b-oq-z]{5}$/);

The same is true for the following test.
I also recommend to ban more chars, as the current test only has a chance of about ~25%(?) to actually the test the expected result.