Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve internet tests #1045

Merged
merged 5 commits into from
Jun 10, 2022
Merged

test: improve internet tests #1045

merged 5 commits into from
Jun 10, 2022

Conversation

Shinigami92
Copy link
Member

related with #1044

@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone Jun 9, 2022
@Shinigami92 Shinigami92 self-assigned this Jun 9, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner June 9, 2022 14:33
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1045 (07b9988) into main (a8e896f) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 07b9988 differs from pull request most recent head 879f2c3. Consider uploading reports for the commit 879f2c3 to get more accurate results

@@            Coverage Diff             @@
##             main    #1045      +/-   ##
==========================================
- Coverage   99.66%   99.64%   -0.02%     
==========================================
  Files        2135     2135              
  Lines      229154   229134      -20     
  Branches      990      974      -16     
==========================================
- Hits       228389   228326      -63     
- Misses        744      787      +43     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 86.95% <0.00%> (-12.47%) ⬇️
src/modules/address/index.ts 98.36% <0.00%> (-0.07%) ⬇️

import-brain
import-brain previously approved these changes Jun 9, 2022
@ST-DDT ST-DDT requested review from a team June 9, 2022 23:34
@Shinigami92 Shinigami92 enabled auto-merge (squash) June 10, 2022 06:37
@Shinigami92 Shinigami92 merged commit 26f89ea into main Jun 10, 2022
@Shinigami92 Shinigami92 deleted the improve-internet-tests branch June 11, 2022 14:41
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
Co-authored-by: xDivisionByZerox <xDivisionByZerox@users.noreply.github.com>
@xDivisionByZerox xDivisionByZerox added the m: internet Something is referring to the internet module label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test m: internet Something is referring to the internet module
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants