Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace setToArray() with Array.from #1050

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

kris71990
Copy link
Contributor

in modules/system/index.ts, replaced setToArray function with Array.from

Re: #1044

@kris71990 kris71990 requested a review from a team as a code owner June 9, 2022 23:07
@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Jun 9, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1050 (1a4e618) into main (26f89ea) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1050   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2135     2135           
  Lines      229154   229134   -20     
  Branches      973      971    -2     
=======================================
- Hits       228344   228329   -15     
+ Misses        789      784    -5     
  Partials       21       21           
Impacted Files Coverage Δ
src/modules/system/index.ts 100.00% <100.00%> (+2.57%) ⬆️
src/modules/internet/user-agent.ts 86.37% <0.00%> (-0.87%) ⬇️
src/modules/finance/index.ts 100.00% <0.00%> (+0.68%) ⬆️

@Shinigami92 Shinigami92 enabled auto-merge (squash) June 10, 2022 06:39
@Shinigami92 Shinigami92 merged commit e466347 into faker-js:main Jun 10, 2022
@kris71990 kris71990 deleted the system-array-from-set branch June 10, 2022 17:42
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
@xDivisionByZerox xDivisionByZerox added the m: system Something is referring to the system module label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior m: system Something is referring to the system module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants