refactor(name.findName): rename to fullName #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDivisionByZerox
added
p: 1-normal
Codecov Report
@@ Coverage Diff @@
## main #1127 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 2146 2146
Lines 230401 230432 +31
Branches 977 976 -1
=======================================
+ Hits 229585 229619 +34
+ Misses 795 792 -3
Partials 21 21
|
ST-DDT
previously approved these changes
Jul 5, 2022
import-brain
previously approved these changes
Jul 6, 2022
xDivisionByZerox
force-pushed
the
refactor/name/rename-find-name-to-full-name
branch
from
9924bdf
to
0af76ac
Compare
|
This is a none blocking/breaking change. So, can we merge this? |
pkuczynski
previously approved these changes
Jul 7, 2022
ST-DDT
previously approved these changes
Jul 9, 2022
|
Would this be merged anytime soon, as I am working on this module and I am afraid of conflicts? |
|
TBH, I don't see what's blocking the merge. Most likely just leaving this open in case anyone still wants a change. Often, many changes are merged in the release week. So I guess in one or two weeks. |
|
Lets just merge it then! No point to keep it hanging. @ST-DDT @Shinigami92 |
xDivisionByZerox
force-pushed
the
refactor/name/rename-find-name-to-full-name
branch
from
00f0d17
to
ce00b3f
Compare
Shinigami92
approved these changes
Jul 19, 2022
ST-DDT
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the existing
faker.name.findName()tofaker.name.fullName(), while keeping the existing function but marking them as deprecated.I also changed the signature of
fullName()to an object for maintainability purposes.I had a discussion with @Shinigami92 last week about deprecations. We came to the conclusion that they should be categorized as
refactorinstead ofchore, what I will start to implement with this PR.