Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(locale.de): update word definition #1148

Merged
merged 5 commits into from Jul 29, 2022

Conversation

xDivisionByZerox
Copy link
Member

This PR updates the word definitions for the german locale.

Updated:

  • adjective

Added:

  • noun
  • adverb
  • verb
  • preposition

@xDivisionByZerox xDivisionByZerox added c: chore PR that doesn't affect the runtime behavior c: locale Permutes locale definitions labels Jul 12, 2022
@xDivisionByZerox xDivisionByZerox added this to the v7 - Current Major milestone Jul 12, 2022
@xDivisionByZerox xDivisionByZerox requested a review from a team July 12, 2022 19:08
@xDivisionByZerox xDivisionByZerox self-assigned this Jul 12, 2022
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner July 12, 2022 19:08
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1148 (4372240) into main (de39d9c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
+ Coverage   99.62%   99.63%   +0.01%     
==========================================
  Files        2148     2152       +4     
  Lines      230582   236201    +5619     
  Branches      979      980       +1     
==========================================
+ Hits       229714   235336    +5622     
+ Misses        847      844       -3     
  Partials       21       21              
Impacted Files Coverage Δ
src/locales/de/word/verb.ts 100.00% <ø> (ø)
src/locales/de/word/adjective.ts 100.00% <100.00%> (ø)
src/locales/de/word/adverb.ts 100.00% <100.00%> (ø)
src/locales/de/word/index.ts 100.00% <100.00%> (ø)
src/locales/de/word/noun.ts 100.00% <100.00%> (ø)
src/locales/de/word/preposition.ts 100.00% <100.00%> (ø)
src/modules/finance/index.ts 100.00% <0.00%> (+0.68%) ⬆️

Copy link
Member

@pkuczynski pkuczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't judge de but I trust that you know what you are doing :)

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like it.
Have you checked whether the adjective list allows for rebundling?
The page sells a product (writing/author class) so they may have interest in keeping it to their own.

@xDivisionByZerox
Copy link
Member Author

I really like it. Have you checked whether the adjective list allows for rebundling? The page sells a product (writing/author class) so they may have interest in keeping it to their own.

I'm aware that the page sells a product, but they introduce it with 'get inspired by our list of adjectives'. So I thought there was no problem with taking the list for whatever reason.

If you want I can check the list against the one from wikipedi, but they are mostly the same (well Wikipedia obviously has much more).

@pkuczynski
Copy link
Member

I would consider Wikipedia more solid source of information...

@xDivisionByZerox xDivisionByZerox added m: word Something is referring to the word module p: 1-normal Nothing urgent labels Jul 28, 2022
@xDivisionByZerox xDivisionByZerox force-pushed the refactor/locale/de/word-definition branch from 87cab73 to 4372240 Compare July 28, 2022 21:33
@ST-DDT ST-DDT merged commit c2c87fb into main Jul 29, 2022
@ST-DDT ST-DDT deleted the refactor/locale/de/word-definition branch July 29, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: locale Permutes locale definitions m: word Something is referring to the word module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants