-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(locale.de): update word definition #1148
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1148 +/- ##
==========================================
+ Coverage 99.62% 99.63% +0.01%
==========================================
Files 2148 2152 +4
Lines 230582 236201 +5619
Branches 979 980 +1
==========================================
+ Hits 229714 235336 +5622
+ Misses 847 844 -3
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't judge de
but I trust that you know what you are doing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like it.
Have you checked whether the adjective list allows for rebundling?
The page sells a product (writing/author class) so they may have interest in keeping it to their own.
I'm aware that the page sells a product, but they introduce it with 'get inspired by our list of adjectives'. So I thought there was no problem with taking the list for whatever reason. If you want I can check the list against the one from wikipedi, but they are mostly the same (well Wikipedia obviously has much more). |
I would consider Wikipedia more solid source of information... |
87cab73
to
4372240
Compare
This PR updates the word definitions for the german locale.
Updated:
Added: