Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensure jsdoc deprecated tag to have a message #1213

Merged
merged 1 commit into from Jul 30, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jul 30, 2022

No description provided.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent c: test labels Jul 30, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Jul 30, 2022
@ST-DDT ST-DDT requested a review from a team July 30, 2022 19:19
@ST-DDT ST-DDT self-assigned this Jul 30, 2022
@ST-DDT ST-DDT requested a review from a team as a code owner July 30, 2022 19:19
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #1213 (54bfec4) into main (ef6fbac) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2153     2153              
  Lines      236521   236521              
  Branches      980      977       -3     
==========================================
- Hits       235654   235633      -21     
- Misses        846      867      +21     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/phone/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 81.74% <0.00%> (-6.35%) ⬇️
src/modules/finance/index.ts 100.00% <0.00%> (+0.68%) ⬆️

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool 👍

@Shinigami92 Shinigami92 merged commit 5589a3c into main Jul 30, 2022
@Shinigami92 Shinigami92 deleted the test/jsdocs/empty-deprecated branch July 30, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: test p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants