Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve getting started #1247

Merged
merged 1 commit into from Aug 9, 2022
Merged

docs: improve getting started #1247

merged 1 commit into from Aug 9, 2022

Conversation

matthewmayer
Copy link
Contributor

a few minor improvements:

  • give an example of how to import with CommonJS
  • use faker.name.fullName instead of deprecated faker.name.findName
  • update the version number in the Deno example

@matthewmayer matthewmayer requested a review from a team August 9, 2022 12:28
@matthewmayer matthewmayer requested a review from a team as a code owner August 9, 2022 12:28
@ST-DDT ST-DDT requested review from a team August 9, 2022 14:02
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Aug 9, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1247 (e40785a) into main (e190506) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1247   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2156     2156           
  Lines      236988   236988           
  Branches     1003     1004    +1     
=======================================
+ Hits       236100   236107    +7     
+ Misses        867      860    -7     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 83.59% <0.00%> (+1.85%) ⬆️

@Shinigami92 Shinigami92 merged commit dddebeb into faker-js:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@Minozzzi Minozzzi Minozzzi approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthewmayer @ST-DDT @Shinigami92 @Minozzzi @import-brain