Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove unused playground #1261

Merged
merged 2 commits into from Aug 12, 2022
Merged

Conversation

Shinigami92
Copy link
Member

closes #1256

  • Removed the unused playground
    • if needed someday, we need to find a way to use it without initially load up >5MB
  • Removed unused Badge component (not even sure what that was 馃し)
  • Cleaned up the unused components folder, but we might need to bring that back if needed

@Shinigami92 Shinigami92 added the c: docs Improvements or additions to documentation label Aug 12, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone Aug 12, 2022
@Shinigami92 Shinigami92 self-assigned this Aug 12, 2022
@Shinigami92 Shinigami92 requested a review from a team August 12, 2022 07:25
@Shinigami92 Shinigami92 requested a review from a team as a code owner August 12, 2022 07:25
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #1261 (bd2069e) into main (5e9c350) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1261   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2156     2156           
  Lines      237025   237025           
  Branches     1006     1006           
=======================================
  Hits       236126   236126           
  Misses        878      878           
  Partials       21       21           

@ST-DDT ST-DDT requested review from a team August 12, 2022 07:55
@Shinigami92 Shinigami92 added the p: 2-high Fix main branch label Aug 12, 2022
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Aug 12, 2022
@Shinigami92 Shinigami92 merged commit 462ee5a into main Aug 12, 2022
@Shinigami92 Shinigami92 deleted the remove-unused-docs-playground branch August 12, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

The docs serve the full faker instance (~5 MB) when visiting fakerjs.dev
3 participants