-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: verify semantic pull requests #1264
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1264 +/- ##
==========================================
- Coverage 99.63% 99.62% -0.02%
==========================================
Files 2154 2156 +2
Lines 239914 237027 -2887
Branches 1007 1006 -1
==========================================
- Hits 239039 236128 -2911
- Misses 854 878 +24
Partials 21 21
|
We need to discuss if we want a type So do we want e.g. But using a type would be somewhat helpful as the |
IMO we should allow type revert. Although this might be connected to a bugfix usually. |
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Cannot name it infra yet, as it's not in the main branch 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add an example commit message for a changed locale file.
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
In our last meeting we discussed that we want to allow only specific defined scopes so the CHANGELOG.md will get better updated automatically
This PR will add a guideline that explains which are good commit/PR titles and which are not (with historical real world examples and how to write them instead)
Also it will only allow a subset of
types
andscopes
so the PR title must follow the new conventionPlease note that the
verifyCommit
script doesn't need to be absolutely exact, as only the PR title is important at the end when merging the PR because we always use squash-merge rebaseTip: You can check how we wrote commit messages in the history with following command: