Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(git): reduce code duplication and follow code style #1271

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Aug 13, 2022

Simplifies the git module by reducing code duplication and following our usual coding style.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent m: git Something is referring to the git module labels Aug 13, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Aug 13, 2022
@ST-DDT ST-DDT requested review from a team August 13, 2022 10:06
@ST-DDT ST-DDT self-assigned this Aug 13, 2022
@codecov
Copy link

codecov bot commented Aug 13, 2022

Codecov Report

Merging #1271 (d53e19a) into main (fda44bb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1271   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2156     2156           
  Lines      237027   237000   -27     
  Branches     1006     1005    -1     
=======================================
- Hits       236128   236111   -17     
+ Misses        878      868   -10     
  Partials       21       21           
Impacted Files Coverage Δ
src/modules/git/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 84.39% <0.00%> (+2.64%) ⬆️

@ST-DDT ST-DDT enabled auto-merge (squash) August 15, 2022 08:19
@ST-DDT ST-DDT merged commit 83e5fd3 into main Aug 15, 2022
@ST-DDT ST-DDT deleted the refactor/git/simplify branch August 15, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior m: git Something is referring to the git module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants