Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 7.5.0 #1319

Merged
merged 5 commits into from Aug 29, 2022
Merged

chore(release): 7.5.0 #1319

merged 5 commits into from Aug 29, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added the c: release Release label Aug 29, 2022
@Shinigami92 Shinigami92 self-assigned this Aug 29, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone Aug 29, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #1319 (8e41ff8) into main (7b18404) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 8e41ff8 differs from pull request most recent head eaa2bcc. Consider uploading reports for the commit eaa2bcc to get more accurate results

@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2160     2160              
  Lines      240614   240614              
  Branches     1017     1014       -3     
==========================================
- Hits       239730   239713      -17     
- Misses        863      880      +17     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 83.59% <0.00%> (-4.50%) ⬇️

@Shinigami92 Shinigami92 marked this pull request as ready for review August 29, 2022 19:27
@Shinigami92 Shinigami92 requested a review from a team as a code owner August 29, 2022 19:27
@Shinigami92 Shinigami92 enabled auto-merge (squash) August 29, 2022 19:39
@xDivisionByZerox
Copy link
Member

But why do you have all these version changes in the package.json file? This should be done y renovate, shouldn't it?

@Shinigami92 Shinigami92 merged commit cc15d9e into main Aug 29, 2022
@ST-DDT ST-DDT deleted the release-7.5.0 branch August 29, 2022 19:43
@Shinigami92
Copy link
Member Author

But why do you have all these version changes in the package.json file? This should be done y renovate, shouldn't it?

Because otherwise while in the release process the pnpm lock file will be regenerated and then it cannot commit it while in release process and then fail

Some of these are also even explicitly omitted by our renovate config (I think)

@Shinigami92
Copy link
Member Author

Shinigami92 commented Aug 29, 2022

So no, the ignores are not in there anymore
I don't know why tsx doesn't got updated, but I think the node types are somehow really special

And eslint-define-config... I mean... it's my project 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: release Release
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants