Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document how to write tests #1398

Merged
merged 6 commits into from Sep 29, 2022
Merged

docs: document how to write tests #1398

merged 6 commits into from Sep 29, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Sep 26, 2022

Fixes #1278

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Sep 26, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Sep 26, 2022
@ST-DDT ST-DDT requested review from a team September 26, 2022 20:48
@ST-DDT ST-DDT self-assigned this Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022 •
edited

Codecov Report

Merging #1398 (36aaa79) into main (2539e6a) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 36aaa79 differs from pull request most recent head 99df459. Consider uploading reports for the commit 99df459 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2163     2163              
  Lines      241306   241303       -3     
  Branches     1017     1013       -4     
==========================================
- Hits       240399   240396       -3     
  Misses        886      886              
  Partials       21       21
Impacted Files Coverage Δ
src/locales/id_ID/address/state.ts 100.00% <0.00%> (ø)

Shinigami92
Shinigami92 reviewed Sep 26, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
import-brain
import-brain reviewed Sep 27, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@ST-DDT @import-brain
chore: apply suggestions
f467375 
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
xDivisionByZerox
xDivisionByZerox reviewed Sep 27, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
xDivisionByZerox
xDivisionByZerox reviewed Sep 27, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
xDivisionByZerox
xDivisionByZerox reviewed Sep 27, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
ST-DDT
ST-DDT commented Sep 27, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
ST-DDT
ST-DDT commented Sep 27, 2022
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
@ST-DDT @xDivisionByZerox
chore: apply suggestions
36aaa79 
Co-authored-by: Leyla Jähnig <leyla.jaehnig@gmx.de>
@ST-DDT ST-DDT requested review from a team September 27, 2022 19:28
@Shinigami92 Shinigami92 enabled auto-merge (squash) September 29, 2022 14:37
@Shinigami92 Shinigami92 merged commit 0bbcb7f into main Sep 29, 2022
@Shinigami92 Shinigami92 deleted the docs/seeded-test-factory-usage branch September 29, 2022 15:14
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
@ST-DDT @wael-fadlallah
docs: document how to write tests (faker-js#1398)
d9f4013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain left review comments

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

Document the usage of the seeded test (factory)
4 participants
@ST-DDT @Shinigami92 @import-brain @xDivisionByZerox