Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix note containers in usage guide #1417

Merged
merged 1 commit into from Oct 8, 2022

Conversation

iamyuu
Copy link
Contributor

@iamyuu iamyuu commented Oct 8, 2022

before:

Screen Shot 2022-10-08 at 07 51 49

after:

Screen Shot 2022-10-08 at 07 52 03

@iamyuu iamyuu requested a review from a team October 8, 2022 00:53
@iamyuu iamyuu requested a review from a team as a code owner October 8, 2022 00:53
@import-brain import-brain added the c: docs Improvements or additions to documentation label Oct 8, 2022
@import-brain import-brain added this to the v7 - Current Major milestone Oct 8, 2022
@import-brain import-brain requested a review from a team October 8, 2022 06:19
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #1417 (663f25c) into main (7327e6e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1417      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2165     2165              
  Lines      241432   241432              
  Branches     1021     1017       -4     
==========================================
- Hits       240549   240525      -24     
- Misses        862      886      +24     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 81.74% <0.00%> (-6.35%) ⬇️

@ST-DDT ST-DDT changed the title docs: improve usage guide for custom containers docs: fix note containers in usage guide Oct 8, 2022
@ST-DDT ST-DDT merged commit f0b60b9 into faker-js:main Oct 8, 2022
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Oct 8, 2022
@iamyuu iamyuu deleted the docs/improve-usage-guide branch October 9, 2022 09:23
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants