infra: move the check-code-generation job to pr.yml #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1419 +/- ##
==========================================
- Coverage 99.62% 99.61% -0.01%
==========================================
Files 2166 2166
Lines 237442 237442
Branches 1041 1040 -1
==========================================
- Hits 236542 236535 -7
- Misses 879 886 +7
Partials 21 21
|
import-brain
added
p: 1-normal
Shinigami92
approved these changes
Oct 10, 2022
ST-DDT
approved these changes
Oct 10, 2022
|
Thanks for the quick fix! |
|
@sunadoi I just want to report you back I LOVE THIS NEW FEATURE 😍 |
|
So happy to hear that!!!🥰 |
wael-fadlallah
pushed a commit
to wael-fadlallah/faker
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check-code-generationCI fails in main branch.This PR Moves the job to
pr.ymland run it only for PRs and not main.#1405 (comment)