Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix CONTRIBUTING.md JSDoc do/dont #1450

Merged
merged 3 commits into from Oct 14, 2022
Merged

docs: fix CONTRIBUTING.md JSDoc do/dont #1450

merged 3 commits into from Oct 14, 2022

Conversation

domingo2000
Copy link
Contributor

Fix #1449

@domingo2000 domingo2000 requested a review from a team October 14, 2022 21:32
@domingo2000 domingo2000 requested a review from a team as a code owner October 14, 2022 21:32
@import-brain import-brain added the c: docs Improvements or additions to documentation label Oct 14, 2022
@import-brain import-brain changed the title infra: fix CONTRIBUTING.md jsdoc separated by empty line do/dont docs: fix CONTRIBUTING.md jsdoc separated by empty line do/dont Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #1450 (b448600) into next (4765336) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head b448600 differs from pull request most recent head ce46e8c. Consider uploading reports for the commit ce46e8c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1450   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files        2164     2164           
  Lines      236816   236816           
  Branches     1000     1003    +3     
=======================================
+ Hits       235893   235912   +19     
+ Misses        901      882   -19     
  Partials       22       22           
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 88.09% <0.00%> (+5.02%) ⬆️

@ST-DDT ST-DDT requested review from a team October 14, 2022 22:33
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Oct 14, 2022
@Shinigami92 Shinigami92 changed the title docs: fix CONTRIBUTING.md jsdoc separated by empty line do/dont docs: fix CONTRIBUTING.md JSDoc do/dont Oct 14, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) October 14, 2022 22:39
@Shinigami92 Shinigami92 merged commit d3fb2c0 into faker-js:next Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CONTRIBUTING.md has swapped Do/Dont in JS Doc empty line section
4 participants