Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove duplicate description tags #1510

Merged
merged 3 commits into from Nov 4, 2022
Merged

docs: remove duplicate description tags #1510

merged 3 commits into from Nov 4, 2022

Conversation

brc-dd
Copy link
Contributor

@brc-dd brc-dd commented Nov 3, 2022

description is already passed through config, there is no need to pass it through head too.

image

@brc-dd brc-dd requested a review from a team November 3, 2022 06:03
@brc-dd brc-dd requested a review from a team as a code owner November 3, 2022 06:03
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #1510 (4f3046b) into next (05e9844) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1510   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2175     2175           
  Lines      237636   237636           
  Branches     1013     1013           
=======================================
  Hits       236782   236782           
  Misses        833      833           
  Partials       21       21           

@Shinigami92 Shinigami92 added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Nov 3, 2022
@Shinigami92 Shinigami92 added this to the v8.0 - Module Re-Shuffling milestone Nov 3, 2022
@ST-DDT ST-DDT requested review from a team November 3, 2022 07:45
@ST-DDT ST-DDT requested a review from a team November 3, 2022 21:50
@ST-DDT ST-DDT merged commit 1452a59 into faker-js:next Nov 4, 2022
@brc-dd brc-dd deleted the patch-3 branch November 4, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants