Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(helpers)!: rewrite shuffle #1521

Merged
merged 6 commits into from Nov 7, 2022
Merged

refactor(helpers)!: rewrite shuffle #1521

merged 6 commits into from Nov 7, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: helpers Something is referring to the helpers module labels Nov 4, 2022
@Shinigami92 Shinigami92 added this to the v8.0 - Module Re-Shuffling milestone Nov 4, 2022
@Shinigami92 Shinigami92 self-assigned this Nov 4, 2022
@Shinigami92 Shinigami92 marked this pull request as ready for review November 4, 2022 17:55
@Shinigami92 Shinigami92 requested a review from a team as a code owner November 4, 2022 17:55
ST-DDT
ST-DDT reviewed Nov 4, 2022
View reviewed changes
src/modules/helpers/index.ts Outdated Show resolved Hide resolved
src/modules/helpers/index.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 4, 2022 •
edited

Codecov Report

Merging #1521 (f881745) into next (7e00d17) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1521   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2214     2214           
  Lines      238669   238701   +32     
  Branches     1015     1014    -1     
=======================================
+ Hits       237813   237845   +32     
  Misses        835      835           
  Partials       21       21
Impacted Files Coverage Δ
src/modules/helpers/index.ts 98.51% <100.00%> (+0.07%) ⬆️

@Shinigami92 @ST-DDT
chore: apply review suggestion
41a4ab9 
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
ST-DDT
ST-DDT previously approved these changes Nov 4, 2022
View reviewed changes
import-brain
import-brain previously approved these changes Nov 4, 2022
View reviewed changes
@Shinigami92 Shinigami92 enabled auto-merge (squash) November 7, 2022 15:43
@Shinigami92 Shinigami92 dismissed stale reviews from import-brain and ST-DDT via e728e6d November 7, 2022 15:46
@Shinigami92 Shinigami92 enabled auto-merge (squash) November 7, 2022 15:46
@Shinigami92 Shinigami92 requested review from a team November 7, 2022 15:47
@Shinigami92 Shinigami92 merged commit a5de229 into next Nov 7, 2022
@ST-DDT ST-DDT deleted the rewrite-helpers-shuffle branch November 7, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: helpers Something is referring to the helpers module
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shinigami92 @ST-DDT @import-brain @xDivisionByZerox