Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(date): clarify the purpose of the context parameter #1576

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Nov 20, 2022

Better document the context parameter of faker.date.weekday() and faker.date.month() since its not used in English.

@matthewmayer matthewmayer requested a review from a team as a code owner November 20, 2022 17:35
@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #1576 (cd9c158) into next (ae7b3ca) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1576   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2220     2220           
  Lines      238957   238957           
  Branches     1035     1035           
=======================================
  Hits       238095   238095           
  Misses        841      841           
  Partials       21       21           
Impacted Files Coverage Δ
src/modules/date/index.ts 99.13% <100.00%> (ø)

@import-brain import-brain added c: docs Improvements or additions to documentation m: date Something is referring to the date module labels Nov 20, 2022
src/modules/date/index.ts Outdated Show resolved Hide resolved
src/modules/date/index.ts Outdated Show resolved Hide resolved
Matt Mayer and others added 4 commits November 21, 2022 07:02
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Nov 21, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Shinigami92
Shinigami92 previously approved these changes Nov 22, 2022
src/modules/date/index.ts Outdated Show resolved Hide resolved
ST-DDT
ST-DDT previously approved these changes Nov 23, 2022
import-brain
import-brain previously approved these changes Nov 23, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
@ST-DDT ST-DDT enabled auto-merge (squash) November 25, 2022 09:29
@ST-DDT ST-DDT merged commit 0af0fff into faker-js:next Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation m: date Something is referring to the date module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants