Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix duplicate test names #1647

Merged
merged 8 commits into from
Dec 17, 2022
Merged

test: fix duplicate test names #1647

merged 8 commits into from
Dec 17, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Dec 9, 2022

While working on

I found that there was a duplicate identifier
this shouldn't be allowed

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: test m: helpers Something is referring to the helpers module labels Dec 9, 2022
@Shinigami92 Shinigami92 added this to the v8.0 - Module Re-Shuffling milestone Dec 9, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner December 9, 2022 12:35
@Shinigami92 Shinigami92 self-assigned this Dec 9, 2022
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #1647 (c1cccdb) into next (0b2fa1a) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1647   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2222     2222           
  Lines      240133   240133           
  Branches     1055     1056    +1     
=======================================
+ Hits       239285   239286    +1     
+ Misses        827      826    -1     
  Partials       21       21           
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 90.81% <0.00%> (+0.27%) ⬆️

ST-DDT
ST-DDT previously approved these changes Dec 9, 2022
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Dec 9, 2022
@ST-DDT ST-DDT requested review from a team December 9, 2022 12:49
@ST-DDT
Copy link
Member

ST-DDT commented Dec 9, 2022

While reviewing this PR I found some more duplicate tests.
I fixed them and added a test to prevent that in the future.

@ST-DDT ST-DDT self-assigned this Dec 9, 2022
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team December 9, 2022 13:21
@ST-DDT ST-DDT changed the title test: fix duplicate test name test: fix duplicate test names Dec 10, 2022
@ST-DDT ST-DDT enabled auto-merge (squash) December 17, 2022 18:59
@ST-DDT ST-DDT merged commit 23c2d3d into next Dec 17, 2022
@ST-DDT ST-DDT deleted the test-fix-duplicate-test-name branch December 17, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants