Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use merge function for locale data #1666

Merged
merged 3 commits into from Dec 16, 2022
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Dec 14, 2022

Simplify the merge of (gendered) locale data and sort the result.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Dec 14, 2022
@ST-DDT ST-DDT self-assigned this Dec 14, 2022
@ST-DDT ST-DDT marked this pull request as ready for review December 14, 2022 16:38
@ST-DDT ST-DDT requested a review from a team as a code owner December 14, 2022 16:38
@ST-DDT ST-DDT requested a review from a team December 14, 2022 16:38
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #1666 (61a1c4a) into next (db6b555) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1666   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2221     2222    +1     
  Lines      240108   240133   +25     
  Branches     1049     1051    +2     
=======================================
+ Hits       239236   239261   +25     
  Misses        851      851           
  Partials       21       21           
Impacted Files Coverage Δ
src/internal/merge.ts 100.00% <100.00%> (ø)
src/locales/cz/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/cz/person/last_name.ts 100.00% <100.00%> (ø)
src/locales/dv/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/dv/person/last_name.ts 100.00% <100.00%> (ø)
src/locales/en_GH/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/fr/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/fr_CH/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/he/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/hu/person/first_name.ts 100.00% <100.00%> (ø)
... and 4 more

Shinigami92
Shinigami92 previously approved these changes Dec 14, 2022
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh that looks very nice and helpful 👍

import-brain
import-brain previously approved these changes Dec 15, 2022
src/internal/merge.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT dismissed stale reviews from import-brain and Shinigami92 via 61a1c4a December 16, 2022 00:08
@ST-DDT ST-DDT requested review from a team December 16, 2022 00:10
@Shinigami92 Shinigami92 merged commit b7dbfac into next Dec 16, 2022
@Shinigami92 Shinigami92 deleted the locales/merge-function branch December 16, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants