feat(helpers): allow empty string in fake

[ST-DDT]

Fixes #1457

• Allow passing empty string to fake() #1457

Allows faker.helpers.fake('') => ''

[codecov]

Codecov Report

Merging #1679 (8b4d962) into next (aa77888) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #1679      +/-   ##
==========================================
- Coverage   99.64%   99.64%   -0.01%     
==========================================
  Files        2240     2240              
  Lines      240106   240098       -8     
  Branches     1072     1068       -4     
==========================================
- Hits       239247   239239       -8     
  Misses        838      838              
  Partials       21       21              

Impacted Files	Coverage Δ
src/modules/helpers/index.ts	99.14% <100.00%> (-0.01%)	⬇️

[xDivisionByZerox]

Is this a breaking change? I (as a user) could have the following case:

function foo(unvalidatedInput: string) {
  try {
    return fake(unvalidatedInput);
  } catch {
    // I use the fact, that faker.helpers.fake() can't handle empty strings
    return myDefaultValue;
  }
}

Just want to get the labels correct and PR title.

[ST-DDT]

If you are relying on the fact that the method throws on empty strings, then yes it is a breaking change.

But:

• We didn't even have a test for that before feat(helpers): fake from array #1453 (merged today)
• We never specified that we would throw in case of an empty string
• We explicitly told the user not to use empty strings

aka it was explicitly undefined behavior before

I'm fine with marking this as breaking or not.

[xDivisionByZerox]

We explicitly told the user not to use empty strings

That's a good point. Then it's not breaking IMO.