Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: remove git commit hooks #1684

Merged
merged 2 commits into from
Dec 26, 2022
Merged

infra: remove git commit hooks #1684

merged 2 commits into from
Dec 26, 2022

Conversation

Shinigami92
Copy link
Member

closes #1683

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Dec 25, 2022
@Shinigami92 Shinigami92 self-assigned this Dec 25, 2022
@codecov
Copy link

codecov bot commented Dec 25, 2022 •
edited

Codecov Report

Merging #1684 (f0b6c72) into next (f0d2ffb) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1684      +/-   ##
==========================================
+ Coverage   99.64%   99.65%   +0.01%     
==========================================
  Files        2240     2240              
  Lines      240098   240098              
  Branches     1068     1072       +4     
==========================================
+ Hits       239239   239263      +24     
+ Misses        838      814      -24     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 91.08% <0.00%> (+6.48%) ⬆️

@Shinigami92 Shinigami92 marked this pull request as ready for review December 25, 2022 14:48
@Shinigami92 Shinigami92 requested a review from a team as a code owner December 25, 2022 14:48
@Shinigami92 Shinigami92 requested a review from a team December 25, 2022 14:50
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Dec 25, 2022
@Shinigami92 Shinigami92 merged commit 2f613cf into next Dec 26, 2022
@Shinigami92 Shinigami92 deleted the 1683-remove-git-commit-hooks branch December 26, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Remove git commit hooks
4 participants
@Shinigami92 @ST-DDT @import-brain @xDivisionByZerox