Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(location)!: countryCode use ISO-3166-1 #1720

Merged
merged 3 commits into from Feb 20, 2023
Merged

refactor(location)!: countryCode use ISO-3166-1 #1720

merged 3 commits into from Feb 20, 2023

Conversation

xDivisionByZerox
Copy link
Member

Scope country code in the location module while satisfying ISO-3166.

@xDivisionByZerox xDivisionByZerox added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release m: location Something is referring to the location module labels Jan 8, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team January 8, 2023 20:46
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner January 8, 2023 20:46
@xDivisionByZerox xDivisionByZerox self-assigned this Jan 8, 2023
@codecov
Copy link

codecov bot commented Jan 8, 2023 •
edited

Codecov Report

Merging #1720 (cc67719) into next (0eba320) will increase coverage by 0.00%.
The diff coverage is 98.16%.

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #1720    +/-   ##
========================================
  Coverage   99.62%   99.63%            
========================================
  Files        2346     2345     -1     
  Lines      236489   236241   -248     
  Branches     1140     1143     +3     
========================================
- Hits       235593   235368   -225     
+ Misses        874      851    -23     
  Partials       22       22
Impacted Files Coverage Δ
src/definitions/location.ts 0.00% <0.00%> (ø)
src/locales/en/location/index.ts 100.00% <ø> (ø)
src/locales/de_CH/location/country_code.ts 100.00% <100.00%> (ø)
src/locales/en/location/country_code.ts 100.00% <100.00%> (ø)
src/locales/fr_CH/location/country_code.ts 100.00% <100.00%> (ø)
src/modules/location/index.ts 98.92% <100.00%> (ø)
src/modules/internet/user-agent.ts 87.86% <0.00%> (+5.32%) ⬆️

@ST-DDT ST-DDT added s: needs decision Needs team/maintainer decision p: 1-normal Nothing urgent labels Jan 8, 2023
@ST-DDT ST-DDT requested a review from a team January 8, 2023 23:38
Shinigami92
Shinigami92 previously approved these changes Jan 17, 2023
View reviewed changes
@Shinigami92 Shinigami92 added the needs rebase There is a merge conflict label Feb 4, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Feb 16, 2023

Team decision

We will keep the locale data as localized data, to allow custom overwrites, but we will switch to [{alpha2, alpha3}] locale data and use the ISO data.

@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision labels Feb 16, 2023
@Shinigami92 Shinigami92 force-pushed the refactor/location/contry-codes-use-iso-3166 branch from 5774a34 to cc67719 Compare February 20, 2023 12:56
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Feb 20, 2023
@Shinigami92 Shinigami92 self-assigned this Feb 20, 2023
@Shinigami92 Shinigami92 requested review from import-brain and a team February 20, 2023 13:07
@ST-DDT ST-DDT mentioned this pull request Feb 20, 2023
Closed
@Shinigami92 Shinigami92 merged commit a05c3e5 into next Feb 20, 2023
@Shinigami92 Shinigami92 deleted the refactor/location/contry-codes-use-iso-3166 branch February 20, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer left review comments

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@Shinigami92 Shinigami92

@xDivisionByZerox xDivisionByZerox

Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xDivisionByZerox @ST-DDT @matthewmayer @Shinigami92 @import-brain