Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove debug code #1724

Merged
merged 3 commits into from Jan 10, 2023
Merged

chore: remove debug code #1724

merged 3 commits into from Jan 10, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 10, 2023

Remove some forgotten debug code from the image tests.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent c: test m: image Something is referring to the image module labels Jan 10, 2023
@ST-DDT ST-DDT requested review from a team January 10, 2023 19:52
@ST-DDT ST-DDT self-assigned this Jan 10, 2023
@xDivisionByZerox
Copy link
Member

I would suggest to type this as chore instead of test.

@ST-DDT ST-DDT changed the title test: remove debug code chore: remove debug code Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (next@d933ccb). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5a42935 differs from pull request most recent head 8a0c884. Consider uploading reports for the commit 8a0c884 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1724   +/-   ##
=======================================
  Coverage        ?   99.63%           
=======================================
  Files           ?     2336           
  Lines           ?   241146           
  Branches        ?     1102           
=======================================
  Hits            ?   240262           
  Misses          ?      863           
  Partials        ?       21

@Shinigami92 Shinigami92 enabled auto-merge (squash) January 10, 2023 20:06
@Shinigami92 Shinigami92 merged commit a7d6875 into next Jan 10, 2023
@ST-DDT ST-DDT deleted the test/image/remove-debug-code branch January 10, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: chore PR that doesn't affect the runtime behavior c: test m: image Something is referring to the image module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ST-DDT @xDivisionByZerox @Shinigami92