build: escape locale import names if they match the module name #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
reviewed
Jan 15, 2023
ST-DDT
added
p: 1-normal
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1737 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 2337 2337
Lines 241178 241178
Branches 1098 1098
=======================================
Hits 240294 240294
Misses 863 863
Partials 21 21 |
ST-DDT
approved these changes
Jan 16, 2023
xDivisionByZerox
approved these changes
Jan 16, 2023
Shinigami92
approved these changes
Jan 17, 2023
ST-DDT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a result of a discussion located here on PR #1699 regarding locale definition imports in locale index files. Prior to this update, locale definition files could not have the same name as their module (e.g.:
src/locales/en/airline/airline.tscould not be used) because the index.ts files that were generated for the locale would have a name conflict. This PR updates thegenerateLocales.tsscript to append an underscore to the imported name of the locale definition and avoid the name conflict.